-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
dep: update libxml2 to v2.11.3, libxslt to v1.1.38 #2866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 28, 2023
e42b512
to
0530f75
Compare
5da08f2
to
cfb6b99
Compare
1f34577
to
fed2627
Compare
20aae82
to
6f3aa6e
Compare
These are not necessary and can be removed.
This is deprecated in libxml2 2.11.0, but we need to check this to make sure we're compatible with libxml-ruby < 3.0.0.
this seems to mirror much faster than uwaterloo.ca
This is a preventative measure because this feature relies on a glibc version we can't realistically require of users today. We're not yet precompiling on a system with a modern-enough glibc to make this an actual problem, but I'm doing it while all of this context is fresh.
6f3aa6e
to
77e4f11
Compare
4e45151
to
cd79753
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
#2865
Note that this PR is a work in progress, see #2865 for status of the overall work.
Have you included adequate test coverage?
One test was modified to accommodate quote-escape behavior that changed.
Does this change affect the behavior of either the C or the Java implementations?
No Nokogiri behaviors have changed, though obviously libxml2 bugfixes have changed some implementation-specific behaviors.