Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

dep: update libxml2 to v2.11.3, libxslt to v1.1.38 #2866

Merged
merged 9 commits into from
May 11, 2023

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Apr 28, 2023

What problem is this PR intended to solve?

#2865

Note that this PR is a work in progress, see #2865 for status of the overall work.

Have you included adequate test coverage?

One test was modified to accommodate quote-escape behavior that changed.

Does this change affect the behavior of either the C or the Java implementations?

No Nokogiri behaviors have changed, though obviously libxml2 bugfixes have changed some implementation-specific behaviors.

@flavorjones flavorjones added this to the v1.15.0 milestone Apr 28, 2023
@flavorjones flavorjones force-pushed the flavorjones-upgrade-libxml2-2.11.0 branch 4 times, most recently from e42b512 to 0530f75 Compare April 28, 2023 22:16
@flavorjones flavorjones changed the title dep: update libxml2 to v2.11.0 from v2.10.4 dep: update libxml2 to v2.11.1 from v2.10.4 Apr 30, 2023
@flavorjones flavorjones force-pushed the flavorjones-upgrade-libxml2-2.11.0 branch 9 times, most recently from 5da08f2 to cfb6b99 Compare May 2, 2023 19:35
@flavorjones flavorjones force-pushed the flavorjones-upgrade-libxml2-2.11.0 branch 11 times, most recently from 1f34577 to fed2627 Compare May 6, 2023 16:24
@flavorjones flavorjones force-pushed the flavorjones-upgrade-libxml2-2.11.0 branch 2 times, most recently from 20aae82 to 6f3aa6e Compare May 6, 2023 16:57
These are not necessary and can be removed.
This is deprecated in libxml2 2.11.0, but we need to check this to
make sure we're compatible with libxml-ruby < 3.0.0.
this seems to mirror much faster than uwaterloo.ca
This is a preventative measure because this feature relies on a glibc
version we can't realistically require of users today.

We're not yet precompiling on a system with a modern-enough glibc to
make this an actual problem, but I'm doing it while all of this
context is fresh.
@flavorjones flavorjones force-pushed the flavorjones-upgrade-libxml2-2.11.0 branch from 6f3aa6e to 77e4f11 Compare May 8, 2023 12:46
@flavorjones flavorjones changed the title dep: update libxml2 to v2.11.1 from v2.10.4 dep: update libxml2 to v2.11.2, libxslt to v1.1.38 May 8, 2023
@flavorjones flavorjones changed the title dep: update libxml2 to v2.11.2, libxslt to v1.1.38 dep: update libxml2 to v2.11.3, libxslt to v1.1.38 May 11, 2023
@flavorjones flavorjones force-pushed the flavorjones-upgrade-libxml2-2.11.0 branch from 4e45151 to cd79753 Compare May 11, 2023 14:14
@flavorjones flavorjones merged commit 32c7543 into main May 11, 2023
@flavorjones flavorjones deleted the flavorjones-upgrade-libxml2-2.11.0 branch May 11, 2023 18:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant