Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update Accessibility of Profile picture picker #1881

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

ermiaSparkle
Copy link
Contributor

@ermiaSparkle ermiaSparkle requested a review from a team as a code owner July 22, 2021 13:36
@ermiaSparkle ermiaSparkle temporarily deployed to feature-preview July 22, 2021 13:36 Inactive
@github-actions github-actions bot added the 💎 styles For (S)CSS style related issues/changes/improvements/etc. label Jul 22, 2021
@codeclimate
Copy link

codeclimate bot commented Jul 22, 2021

Code Climate has analyzed commit be2ea39 and detected 0 issues on this pull request.

View more on Code Climate.

@ermiaSparkle ermiaSparkle added accessibility and removed 💎 styles For (S)CSS style related issues/changes/improvements/etc. labels Jul 22, 2021
@github-actions
Copy link

github-actions bot commented Jul 22, 2021

Visit the preview URL for this PR (updated for commit be2ea39):

https://co-reality-staging--preview-pr-1881-86eq2k1h.web.app

(expires Thu, 29 Jul 2021 14:12:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ermiaSparkle ermiaSparkle changed the title update Accessibility of this page update Accessibility of Profile picture picker Jul 22, 2021
@ermiaSparkle ermiaSparkle requested a review from mike-lvov July 22, 2021 13:56
Copy link
Contributor

@mike-lvov mike-lvov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this? Do we need it?
#1863

@ermiaSparkle ermiaSparkle reopened this Jul 22, 2021
@ermiaSparkle ermiaSparkle temporarily deployed to feature-preview July 22, 2021 14:03 Inactive
@github-actions github-actions bot added the 💎 styles For (S)CSS style related issues/changes/improvements/etc. label Jul 22, 2021
@mike-lvov mike-lvov temporarily deployed to feature-preview July 22, 2021 14:08 Inactive
@mike-lvov
Copy link
Contributor

@ermiaSparkle his changes should be applied to staging. If you could review those, it would be great.

@mike-lvov mike-lvov merged commit 6d1cf38 into staging Jul 22, 2021
@mike-lvov mike-lvov deleted the ermia/Accessibility-upload-profile-pics branch July 22, 2021 14:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
accessibility 💎 styles For (S)CSS style related issues/changes/improvements/etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants