Add proper boolean conversion to xml representation #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SanderMuller you pointed to my previous PR about converting to |
Looks good, since it's opt-in it shouldn't be a breaking change |
|
Thanks! |
|
Welcome, it was needed for my requirements anyway :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, boolean values are converted incorrectly. Only
truevalue is converted to 1 which is allowed value.falseis converted as an empty attribute, which is incorrect.Based on https://www.w3.org/TR/xmlschema-2/#boolean
true, false, 1, 0are allowed values.We don't want to break previous behavior so that feature can be enabled by option.