New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feature: Betterify Tests #457

Merged

freekmurze merged 1 commit into spatie:main from mansoorkhan96:feature/betterify-tests

May 5, 2022

Contributor

mansoorkhan96 commented May 5, 2022 •

edited

Loading

Hi👋
This PR improves some tests by replacing expectations on hardcoded dates with Carbon instances.

Example
From this:

Carbon::setTestNow(Carbon::create(2016, 1, 1));

$period = Period::days(10);

expect($period->startDate->format('Y-m-d'))->toBe('2015-12-22');
expect($period->endDate->format('Y-m-d'))->toBe('2016-01-01');

To This:

$expectedDate = Carbon::create(2016, 1, 1);
Carbon::setTestNow($expectedDate);

$period = Period::days(10);

expect($period)
    ->endDate->toEqual($expectedDate)
    ->startDate->toEqual($expectedDate->subDays(10));

Plus, also refactors to possibly use higher-order expectations.


          Feaure: Betterify Tests

b49db38

freekmurze merged commit c89c3ae into spatie:main

Member

freekmurze commented May 5, 2022

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet