Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes not dispatching SpamDetectedEvent in Livewire #120

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

fsamapoor
Copy link

@fsamapoor fsamapoor commented Jul 14, 2023

I noticed the SpamDetectedEvent event does not dispatch in the Livewire components and in this PR, I have made the required adjustment.

I didn't know whether this was something that should be covered in the test suite. So I figured I should update the tests in a separate commit so that we can cherry-pick the first one if the tests are redundant.

Please tell me if I could do better with the tests.

@freekmurze freekmurze merged commit 4458306 into spatie:main Jul 17, 2023
@freekmurze
Copy link
Member

Thanks!

@fsamapoor fsamapoor deleted the fix_event_dispatching_in_livewire branch July 18, 2023 06:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants