Merge pull request #87 from bvtterfly/patch-1

Fix LaravelVersion
spatie · Apr 14, 2022 · 924d1ae · 924d1ae
2 parents d8c6991 + e199aea
commit 924d1ae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/Support/LaravelDocumentationLinkFinder.php b/src/Support/LaravelDocumentationLinkFinder.php
@@ -15,7 +15,7 @@ public function findLinkForThrowable(Throwable $throwable): ?string
             $throwable = $throwable->getPrevious();
         }
 
-        $majorVersion = explode('.', app()->version())[0];
+        $majorVersion = LaravelVersion::major();
 
         if (str_contains($throwable->getMessage(), Collection::class)) {
             return "https://laravel.com/docs/{$majorVersion}.x/collections#available-methods";

diff --git a/src/Support/LaravelVersion.php b/src/Support/LaravelVersion.php
@@ -6,6 +6,6 @@ class LaravelVersion
 {
     public static function major(): string
     {
-        return substr(app()->version(), 0, 1);
+        return explode('.', app()->version())[0];
     }
 }
diff --git a/tests/Support/LaravelDocumentationLinkFinderTest.php b/tests/Support/LaravelDocumentationLinkFinderTest.php
@@ -2,6 +2,7 @@
 
 use Illuminate\Auth\AuthenticationException;
 use Spatie\LaravelIgnition\Support\LaravelDocumentationLinkFinder;
+use Spatie\LaravelIgnition\Support\LaravelVersion;
 
 beforeEach(function () {
     $this->finder = new LaravelDocumentationLinkFinder();
@@ -10,7 +11,7 @@
 it('can find a link for a laravel exception', function () {
     $link = $this->finder->findLinkForThrowable(new AuthenticationException());
 
-    $majorVersion = explode('.', app()->version())[0];
+    $majorVersion = LaravelVersion::major();
 
     expect($link)->toEqual("https://laravel.com/docs/{$majorVersion}.x/authentication");
 });