Allow withResponsiveImages to be conditionally set (#3742)

* Allow withResponsiveImages to be set to false This is to reset the value if it was previously set true, for instance in an additional media library package. * Update ResponsiveImageTest.php test
spatie · Dec 9, 2024 · e041e39 · e041e39
1 parent fcc900a
commit e041e39
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/Conversions/Conversion.php b/src/Conversions/Conversion.php
@@ -186,9 +186,9 @@ public function nonOptimized(): self
         return $this;
     }
 
-    public function withResponsiveImages(): self
+    public function withResponsiveImages(bool $withResponsiveImages = true): self
     {
-        $this->generateResponsiveImages = true;
+        $this->generateResponsiveImages = $withResponsiveImages;
 
         return $this;
     }

diff --git a/tests/ResponsiveImages/ResponsiveImageTest.php b/tests/ResponsiveImages/ResponsiveImageTest.php
@@ -112,3 +112,18 @@
 
     expect($media->getResponsiveImageUrls('non-existing-conversion'))->toBe([]);
 });
+
+test('a media instance can be set to not generate responsive urls', function () {
+    $this
+        ->testModelWithResponsiveImages
+        ->addMedia($this->getTestJpg())
+        ->withResponsiveImages()
+        ->withResponsiveImages(false)
+        ->toMediaCollection();
+
+    $media = $this->testModelWithResponsiveImages->getFirstMedia();
+
+    expect($media->hasResponsiveImages())->toBeFalse();
+
+    expect($media->hasResponsiveImages('thumb'))->toBeFalse();
+});