Add public for ->writeToDisk() as option #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add visibility option for sitemap index.
Add visibility option
Add public private visibility option
Update SitemapIndex.php For S3 Public Storage Option
freekmurze
requested changes
Jan 17, 2024
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using S3 for hosting my sitemaps(Using Vapor for the site so local disk isn't an option).
I'm currently generating the sitemap and after creation, I'm then changing the visibility to public. This could cause, though rare, a race condition of me creating the sitemap and before making it public, a search engine crawler would receive a "Access Denied" error from S3.
By adding the visibility option as seen here(https://laravel.com/docs/10.x/filesystem#file-visibility), it resolves this issue.