Detect migrations automatically in TestCase
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Thank you for the nice package, I've used it a lot on (I think) all my packages!
Currently, in the
TestCasefile, people have to manually provide their migration paths. I've always found this a bit surprising/not-DX friendly, as it is very easy to just get and run all migrations instead of manually needing to provide the full path(s). Therefore, this PR replaces it with a simple snippet to just run all migrations in thedatabase/migrationspath.The snippet is using the
File::allFiles()method. This is fine, the only thing is that people would need to import the file after uncommenting for the most clean result. Alternatives like thescandir()function are also not great, asscandir()is returning results like.or..and then the snippet to un-comment would start to contain if-conditions, even less nice.Thanks!