Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Nested Data Proposal (SDFG only) #1324

Merged
merged 46 commits into from
Aug 22, 2023
Merged

Nested Data Proposal (SDFG only) #1324

merged 46 commits into from
Aug 22, 2023

Conversation

alexnick83
Copy link
Contributor

@alexnick83 alexnick83 commented Jul 19, 2023 •
edited
Loading

This PR implements the Nested Data proposal only for the SDFG IR (no frontend support).

alexnick83 added 30 commits July 18, 2023 14:41
@alexnick83
Added NestedDataClassProperty for nested data.
57abd28
@alexnick83
Added Structures and StructArrays.
09465d2
@alexnick83
Break array lengths down to their symbolic tokents.
51776a1
@alexnick83
Allow structures to have fields whose name doesn't start with undersc…
b23ed86 
…ore.
@alexnick83
Structures now have a "members" dictionary. Their dtype is a pointer …
777821f 
…to the corresponding dtypes.struct typeclass.
@alexnick83
dtype.structs store their ctype in _FFI_CTYPES.
ebf7206
@alexnick83
Reverted underscore exception for Structures.
c52a482
@alexnick83
Small fixes.
40cc858
@alexnick83
WIP: Replace ',' with '->' to quickly support nested data.
dd73aaa
@alexnick83
Recursively add to arglist nested data descriptors.
623a7f8
@alexnick83
Recursively look into nested data to emit definitions.
1e5badd
@alexnick83
SDFG data (_arrays) are now stored in a NestedDict.
36d4e82
@alexnick83
Adjusted the matching check for memlet data and src/dst nodes to not …
38a4265 
…fail for Structures.
@alexnick83
Added tests.
479cb2a
@alexnick83
Serialization fixes.
8365ab3
@alexnick83
Fixed NestedDict for non-str keys.
14ba665
@alexnick83
Added support for transient Structures.
80d6f10
@alexnick83
Edited tests.
9658c22
@alexnick83
Structures have name attribute (instead of subclassing).
b1dbb6b
@alexnick83
Updated tests.
5de2ae3
@alexnick83
Removed nested data connectors.
1fbc45f
@alexnick83
Added support for direct access to nested data.
6fa7e53
@alexnick83
WIP: Add nested data free symbols to SDFG.
71d7c3d
@alexnick83
Added test for direct nested data access.
e0a4409
@alexnick83
Added test for direct double-nested data accesses.
0593ea4
@alexnick83
Added free-symbols and repr.
0df9c35
@alexnick83
Recursively add free symbols from nested data.
909c1aa
@alexnick83
Updated tests.
e2b0d8b
@alexnick83
Scrapped structure private symbols for now.
52afc72
@alexnick83
Merge branch 'master' into nested-data-sdfg
a0e3458
tbennun
tbennun reviewed Jul 21, 2023
View reviewed changes
@alexnick83 alexnick83 marked this pull request as ready for review August 17, 2023 13:59
@alexnick83 alexnick83 requested a review from tbennun August 17, 2023 13:59
tbennun
tbennun requested changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No design issues

@alexnick83 alexnick83 requested a review from tbennun August 22, 2023 13:52
tbennun
tbennun approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexnick83 alexnick83 merged commit f99bbca into master Aug 22, 2023
@alexnick83 alexnick83 deleted the nested-data-sdfg branch August 22, 2023 18:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@phschaad phschaad phschaad left review comments

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexnick83 @tbennun @phschaad