Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve the HTML only file format #28

Merged
merged 1 commit into from
Apr 14, 2018
Merged

Improve the HTML only file format #28

merged 1 commit into from
Apr 14, 2018

Conversation

goneall
Copy link
Member

@goneall goneall commented Apr 13, 2018

Fixed by using the complete HTML format from the license XML specified input file

Signed-off-by: Gary O'Neall gary@sourceauditor.com

…rom the license XML specified input file

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@wking
Copy link
Contributor

wking commented Apr 13, 2018

What is throwing InvalidLicenseTemplateException? Is that a bug in a parser here? A bug in the upstream XML? This fallback feels like a workaround for an issue we shouldn't be having, but I am Java-illiterate, so maybe I'm just missing something obvious ;).

@goneall
Copy link
Member Author

goneall commented Apr 14, 2018

What is throwing InvalidLicenseTemplateException?

There is a library with a function that checks for invalid templates and throws and exception if there is an error. In this particular scenario, it should never occur but I decided to just fall back to the previous code rather than pass along the exception. Two reasons I decided on this approach - the fallback still produces a reasonable result and to pass along the exception would require a change in the interface which would have impacted a lot more code.

@goneall goneall merged commit f56759c into master Apr 14, 2018
@goneall goneall deleted the htmlfix branch April 14, 2018 14:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants