Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update description and links #89

Merged
merged 5 commits into from
Feb 18, 2021
Merged

update description and links #89

merged 5 commits into from
Feb 18, 2021

Conversation

jlovejoy
Copy link
Member

update description and links to be current

update description and links to be current
@jlovejoy jlovejoy self-assigned this Nov 25, 2020
@jlovejoy
Copy link
Member Author

@swinslow - please have a look!

Copy link
Member

@swinslow swinslow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jlovejoy, the substance of this looks good to me. There are a few necessary formatting edits (missing closing </a> tags to be added and possibly an extra </ul> tag to be deleted), and a few less-necessary recommended edits to update URLs.

I'm making changes to the version that I'm implementing on the live site for the 3.11 release to address these comments, and I will circle back to update them in this PR -- or feel free to make the edits here yourself if you have time. Thanks!

@goneall
Copy link
Member

goneall commented Feb 5, 2021

@jlovejoy @swinslow There is a change request on this PR - if you could review/update I can merge in the changes before the next license list release.

Signed-off-by: Steve Winslow <steve@swinslow.net>
Signed-off-by: Steve Winslow <steve@swinslow.net>
Signed-off-by: Steve Winslow <steve@swinslow.net>
@swinslow
Copy link
Member

Thanks @goneall, I've pushed the changes to fix the issues I flagged above -- should be good to go now.

@goneall
Copy link
Member

goneall commented Feb 18, 2021

Thanks @swinslow !

@goneall goneall merged commit f733296 into master Feb 18, 2021
@goneall goneall deleted the jlovejoy-ToC branch February 18, 2021 18:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants