Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update LicenseListPublisher to version 3.0.1 #2639

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Update LicenseListPublisher to version 3.0.1 #2639

merged 1 commit into from
Dec 20, 2024

Conversation

goneall
Copy link
Member

@goneall goneall commented Dec 20, 2024

In addition to the changes in version 3.0.0, this release fixes the test-single-license mentioned in this comment.

This release also add support for full testing of license texts. The full testing is now done in the CI when there is a pull request or merge to main. The script test-single-license has also been updated to do full testing for the single license being tested.

To add a positive test for text that should match, add text of the file under test/fullTestForGenerator/{license-or-exceptionId}/good/{test-id}.txt

To add a negative test for text that should not match, add text of the file under test/fullTestForGenerator/{license-or-exceptionId}/bad/{test-id}.txt

@goneall
Copy link
Member Author

goneall commented Dec 20, 2024

@xsuchy - Could you give the single-license-text a try on this branch (pub301) and let me know if you run into any issues?

@goneall goneall marked this pull request as ready for review December 20, 2024 00:23
@goneall
Copy link
Member Author

goneall commented Dec 20, 2024

We should probably add the new test directory to the documentation - @swinslow - if you could point me to where this is documented, I can do an update in this PR or in a subsequent PR.

@xsuchy
Copy link
Collaborator

xsuchy commented Dec 20, 2024

We should probably add the new test directory to the documentation

Yes. But in separate PR.
I am afraid the testsuite is not documented anywhere. We need to start a document from scratch.

@xsuchy
Copy link
Collaborator

xsuchy commented Dec 20, 2024

$ ./test-one-license BSD-3-Clause
SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.
License passed

the info text is still there. But the test passes now.

+1

@xsuchy xsuchy merged commit e9189ef into main Dec 20, 2024
5 checks passed
@xsuchy
Copy link
Collaborator

xsuchy commented Dec 20, 2024

Thank you.

@swinslow
Copy link
Member

Thank you both! @goneall I added #2649 to track this for 3.27.0 -- I'll follow up in that issue for tracking purposes.

@swinslow swinslow deleted the pub301 branch December 30, 2024 16:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants