feat: plumb validation warnings into studio (#1345)

The studio currently displays:
- ValidationErrors – Generated from rule evaluations and explicitly
added errors.
- Explicitly added Diagnostics – generally suggestions

Both are transformed into a type (confusingly named Diagnostic) that
includes key details like the message, line number, schema path,
severity, and type. These diagnostics are then rendered in the studio.

However, a category of validation issues visible in the CLI but missing
from the studio are those logged via logging.LogWarning. This change
ensures these warnings are also surfaced in the studio, providing a more
consistent experience.


https://github.com/user-attachments/assets/bd1cc8f7-2441-4a7f-bcc8-270c93006abf

Author: vishalg0wda

internal/studio/studioHelpers.go

@@ -160,8 +160,12 @@ func convertSourceResultIntoSourceResponseData(sourceResult run.SourceResult, so
 					Line:     pointer.ToInt64(int64(vErr.LineNumber)),
 					Type:     vErr.Rule,
 				})
+				continue
 			}
 		}
+		for _, w := range sourceResult.LintResult.Warnings {
+			diagnosis = append(diagnosis, convertWarningToDiagnostic(w))
+		}
 	}
 
 	for t, d := range sourceResult.Diagnosis {
@@ -208,6 +212,45 @@ func convertSourceResultIntoSourceResponseData(sourceResult run.SourceResult, so
 	}, nil
 }
 
+func convertWarningToDiagnostic(w error) components.Diagnostic {
+	if vErr, ok := w.(*vErrs.ValidationError); ok {
+		return components.Diagnostic{
+			Message:  vErr.Message,
+			Severity: string(vErr.Severity),
+			Line:     pointer.ToInt64(int64(vErr.LineNumber)),
+			Type:     vErr.Rule,
+			Path:     []string{vErr.Path},
+		}
+	}
+
+	if uErr, ok := w.(*vErrs.UnsupportedError); ok {
+		return components.Diagnostic{
+			Message:  uErr.Message,
+			Line:     pointer.ToInt64(int64(uErr.LineNumber)),
+			Severity: "warn",
+			Type:     "Unsupported",
+		}
+	}
+
+	// TODO: Try to extract the warning type, message, and line number at a minimum
+	// parts := strings.Split(w.Error(), ":")
+	// if len(parts) == 2 {
+	// 	warnType := strings.TrimSpace(parts[0])
+	// 	message := strings.TrimSpace(parts[1])
+	// 	return components.Diagnostic{
+	// 		Message:  message,
+	// 		Severity: "warn",
+	// 		Type:     warnType,
+	// 	}
+	// }
+
+	return components.Diagnostic{
+		Message:  w.Error(),
+		Severity: "warn",
+		Type:     "Warnings",
+	}
+}
+
 func convertWorkflowToComponentsWorkflow(w workflow.Workflow, workingDir string) (components.Workflow, error) {
 	// 1. Marshal to JSON
 	// 2. Unmarshal to components.Workflow

internal/validation/openapi.go

@@ -331,7 +331,7 @@ func Validate(ctx context.Context, outputLogger log.Logger, schema []byte, schem
 
 	if len(vErrs) > 0 {
 		status = "OpenAPI document invalid ✖"
-	} else if len(vErrs) > 0 {
+	} else if len(vWarns) > 0 {
 		status = "OpenAPI document valid with warnings ⚠"
 	}