feat: plumb validation warnings into studio #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalg0wda
force-pushed
the
vishal/gen-1264-bug-plumb-validation-warnings-into-studio
branch
from
2711f7d to
445647c
Compare
vishalg0wda
changed the title
vishalg0wda
changed the title
vishalg0wda
force-pushed
the
vishal/gen-1264-bug-plumb-validation-warnings-into-studio
branch
from
445647c to
cf4e4a2
Compare
adaam2
approved these changes
Mar 22, 2025
vishalg0wda
deleted the
vishal/gen-1264-bug-plumb-validation-warnings-into-studio
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The studio currently displays:
Both are transformed into a type (confusingly named Diagnostic) that includes key details like the message, line number, schema path, severity, and type. These diagnostics are then rendered in the studio.
However, a category of validation issues visible in the CLI but missing from the studio are those logged via logging.LogWarning. This change ensures these warnings are also surfaced in the studio, providing a more consistent experience.
Screencast.From.2025-03-20.16-33-00.mp4