-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add header image #62
Add header image #62
Conversation
@spenserblack ready for review also consider dropping the "Features" header. maybe even combine the emoji list with the test status badge? 🌐 Works across repositories (with a [PAT]) or 🌐 Works across repositories (with a [PAT]) |
Yeah, I'm fine dropping the features header. I think the picture tells enough of a story. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but are you planning to make any more changes, like dropping the features section like you mentioned?
@spenserblack yep how does this look?
specifically: where should the Test badge go (if anywhere)? |
Personally, I like badges for the most important aspects of the project (CI/Tests passing, package version, etc.) up at the top, right under the title. It's where I've put badges in pretty much every project, and also where I've seen badges in other projects. As a user, seeing a nice "tests pass" badge at the top before I even start reading the docs is reassuring. |
@spenserblack i made it like you want: ready2merge |
this pr would...
closes #39