Handle no-changed situation

[yo-ga]

Fix #76

git diff-index --quiet HEAD -- sometimes doesn't handle the no-changed situation.
Use git status --porcelain to handle modified, created, and deleted.

[jcbhmr]

another option (not necessarily the one that we should go with 🤷‍♀️) is to just --allow-empty and ditch the "Are there any changes?" question

git add -A
git commit --allow-empty -m "$INPUT_COMMIT_MESSAGE"
#          ^^^^^^^^^^^^^

[yo-ga]

another option (not necessarily the one that we should go with 🤷‍♀️) is to just --allow-empty and ditch the "Are there any changes?" question

However, if we have already handled no-changed situation and exit from the script, there may be no situation to use allow-empty.

[yo-ga]

I think there is a potential issue about testing in different scenarios. For now, the test is for modified.

[jcbhmr]

Here's a concrete demo of what I mean from an alternative GitHub wiki action:

https://github.com/Andrew-Chen-Wang/github-wiki-action/blob/jcbhmr/src/clone.sh#L90

# Allowing an empty commit is way easier than detecting empty commits! This also
# makes semantic sense. If you run this action, it adds a commit to your wiki.
# How large that commit is comes down to your changes. 0 change = commit with 0.
# This works well with the default "Update wiki ${{ github.sha }}" message so
# that even if the commit is empty, the message has the SHA there.
git commit --allow-empty -m "$INPUT_COMMIT_MESSAGE"

[jcbhmr]

I think this looks like a good fix! Thanks for including the StackOverflow link too ❤️
@spenserblack is the owner with write perms, so we'll need to wait for a-OK from them.

[yo-ga]

If we use allow-empty, we can easily validate whether the wiki is kept up with the latest commit. Otherwise, we can easily know when the wiki is changed and what differences are between the wiki revision. It's up to you.

[spenserblack]

LGTM!

As far as --allow-empty goes, IMO this would be some sort of input the user would have so that they would have the choice. So, in pseudocode, basically it would be this:

if git_has_changes OR input.allow_empty:
    commit()
else:
    report_empty()

[spenserblack]

Oh, and as far as testing goes, TBH I'd want to switch over to using JS/TS before testing in-depth.

[yo-ga]

Hi @spenserblack, will a new version be released soon?

[spenserblack]

@all-contributors add @yo-ga for code

[allcontributors]

@spenserblack

I've put up a pull request to add @yo-ga! 🎉

[spenserblack]

https://github.com/spenserblack/actions-wiki/releases/tag/v0.3.0 🙂