Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use correct stale action exempt-* yaml keys #1800

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Use correct stale action exempt-* yaml keys #1800

merged 1 commit into from
Sep 8, 2022

Conversation

jpmcb
Copy link
Collaborator

@jpmcb jpmcb commented Sep 7, 2022

Somehow we had the wrong exempt- keys in our stale action yaml (or maybe they changed it) causing the stale action to label some lifecycle/frozen issues and PR as stale.

This should fix that and make lifecycle/frozen labeling do the right thing

@github-actions github-actions bot added area/github For changes to Github specific things not shipped in the library size/XS Denotes a PR that changes 0-9 lines labels Sep 7, 2022
Signed-off-by: John McBride <jpmmcbride@gmail.com>
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out!

@marckhouzam marckhouzam added the lgtm Denotes "looks good to me" from maintainers and signals other collaboratores that a PR is ready label Sep 8, 2022
@jpmcb jpmcb merged commit 2e8ba6f into spf13:main Sep 8, 2022
@jpmcb jpmcb deleted the main branch September 8, 2022 00:25
@jpmcb
Copy link
Collaborator Author

jpmcb commented Sep 8, 2022

Thanks Marc!!!

@umarcor umarcor mentioned this pull request Sep 9, 2022
jimschubert added a commit to jimschubert/cobra that referenced this pull request Oct 3, 2022
* main: (39 commits)
  Add '--version' flag to Help output (spf13#1707)
  Expose ValidateRequiredFlags and ValidateFlagGroups (spf13#1760)
  Document option to hide the default completion cmd (spf13#1779)
  ci: add workflow_dispatch (spf13#1387)
  add missing license headers (spf13#1809)
  ci: use action/setup-go's cache (spf13#1783)
  Adjustments to documentation (spf13#1656)
  Rename Powershell completion tests (spf13#1803)
  Support for case-insensitive command names (spf13#1802)
  Deprecate ExactValidArgs() and test combinations of args validators (spf13#1643)
  Use correct stale action `exempt-` yaml keys (spf13#1800)
  With go 1.18, we must use go install for a binary (spf13#1726)
  Clarify SetContext documentation (spf13#1748)
  ci: test on Golang 1.19 (spf13#1782)
  fix: show flags that shadow parent persistent flag in child help (spf13#1776)
  Update gopkg.in/yaml.v2 to gopkg.in/yaml.v3 (spf13#1766)
  fix(bash-v2): activeHelp length check syntax (spf13#1762)
  fix: correct command path in see_also for YAML doc (spf13#1771)
  build(deps): bump github.com/inconshreveable/mousetrap (spf13#1774)
  docs: add zitadel to the list (spf13#1772)
  ...
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/github For changes to Github specific things not shipped in the library lgtm Denotes "looks good to me" from maintainers and signals other collaboratores that a PR is ready size/XS Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants