fix CompletionFunc implementation #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new type CompletionFunc could lead to a regression. This commit adds a test to ensure that the completion function is correctly The tests are currently failing. This is expected as the fix is not yet implemented. Signed-off-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Signed-off-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
This was referenced Feb 16, 2025
|
I provided a separate commit so anyone reviewing could fetch and check. I covered the possible issue such as type UserCompletionTypeHelper func(cmd *Command, args []string, toComplete string) ([]string, ShellCompDirective)
type UserCompletionTypeAliasHelper = func(cmd *Command, args []string, toComplete string) ([]string, ShellCompDirective)Please review @marckhouzam @thaJeztah @tassa-yoniso-manasi-karoto Thanks |
|
I'm reviewing this now. Thanks for the quick fix @ccoVeille ! |
marckhouzam
approved these changes
Feb 16, 2025
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Feb 16, 2025
Using the branch from spf13/cobra#2234 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Tested locally and build works with this PR (failed with v1.9.0); just pushed a draft PR to also have it run in CI docker/cli#5829 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about this