Skip to content

linkcheck: disallow 'None' value for 'linkcheck_allowed_redirects' setting #13483

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jayaddison
Copy link
Contributor

Purpose

Patches the linkcheck module so that linkcheck_allowed_redirects is never assigned a value of None -- this was failing to typecheck against the allowed values for the config value when HTML themes were enabled (ref: #13462).

The range of possible values for the config setting are:

  • linkcheck_allowed_redirects:{}: default follow redirects to attempt to resolve them, and emit warnings when redirects occur.
  • linkcheck_allowed_redirects:_sentinel_lar: follow redirects to attempt to resolve them, and do not warn about them.
  • linkcheck_allowed_redirects:{...}: follow redirects to attempt to resolve them, and warn about any that do not resolve to the expected destinations.

References

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible regression in linkcheck_allowed_redirects default following PR 13452
1 participant