Fix: Empty string enum rendering + Add configurable amount of choices to display #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insspb
changed the title
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 314 309 -5
=========================================
- Hits 314 309 -5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
timobrembeck
requested changes
Jun 13, 2023
|
@timoludwig Any news? |
Co-authored-by: Timo Ludwig <ti.ludwig@web.de>
timobrembeck
approved these changes
Jul 2, 2023
ntouran
added a commit
to ntouran/sphinxcontrib-django
that referenced
this pull request
Aug 16, 2023
Fixes sphinx-doc#42. The tests intended to capture the issue but actually don't trigger the real issue in the test scenario, so they may not be appropriate. I tried making a 2nd app to see if the deferred issue would show up but it does not.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix text choices rendering problem, from issue #41 and also it add completely clear approach to configure amount of choices to render (with sphinx option).
fixes #41
@timoludwig Please merge it