Kubernetes clone server group operation #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| newDescription.loadBalancers = [] | ||
| newDescription.securityGroups = [] | ||
| ancestorServerGroup.spec?.template?.metadata?.labels?.each { key, val -> | ||
| if (key.startsWith("load-balancer-")) { |
There was a problem hiding this comment.
You should move this logic into KubernetesUtil
|
@spinnaker/google addressed all comments, ptal |
|
|
||
| CloneKubernetesAtomicOperationDescription description | ||
|
|
||
| /* |
|
LGTM. Please rebase and squash all commits. |
skim1420
force-pushed
the
kubernetes-clone-op
branch
from
33db473 to
7d888f8
Compare
skim1420
force-pushed
the
kubernetes-clone-op
branch
from
7d888f8 to
a4772c4
Compare
duftler
pushed a commit
that referenced
this pull request
Jan 6, 2016
Kubernetes clone server group operation
|
✨ |
luba239
pushed a commit
to vasiliy-briginets/clouddriver
that referenced
this pull request
Mar 5, 2020
ttomsu
pushed a commit
to ttomsu/clouddriver
that referenced
this pull request
Mar 11, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spinnaker/google