provider/kubernetes: Register docker registry credentials. #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,9 +31,27 @@ public class DockerRegistryNamedAccountCredentials implements AccountCredentials | |||
| public DockerRegistryNamedAccountCredentials(String accountName, String environment, String accountType, | |||
| String address, String username, String password, String email, | |||
| List<String> repositories, List<String> requiredGroupMembership) { | |||
| if (!accountName || accountName.length() == 0) { | |||
There was a problem hiding this comment.
Can just be if (!accountName).
|
LGTM. Feel free to self-merge after addressing comments and rebasing. |
This PR achieves 2 things. 1. The Kubernetes user can define a list of docker registry accounts whose credentials and endpoint will be registered with as a secret with the Kubernetes master. You can read more about how this works [here](http://kubernetes.io/v1.0/docs/user-guide/images.html). The user can also provide an optional list of namespaces (if omitted, every namespace is used) that this registry can be used to deploy images to. The motivation here is to allow users to configure repositories with images specifically for test, prod, staging, etc, if they want to. 2. While writing the mock tests, I was frustrated with the fact that `KubernetesUtil` was non-static, and had a subset of kubernetes API functionality built in. I took this functionality out, made the remainder static, and placed it into `KubernetesApiAdaptor`. I will now do all API calls through this class. If we need to plug in a separate Kubernetes API it will be easy to abstract and then subclass `KubernetesApiAdaptor`.
lwander
force-pushed
the
kubernetes-registry-secret
branch
from
7aee9af to
eccc560
Compare
lwander
added a commit
that referenced
this pull request
Feb 9, 2016
provider/kubernetes: Register docker registry credentials.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR achieves 2 things.
KubernetesUtilwas non-static, and had a subset of kubernetes API functionality built in. I took this functionality out, made the remainder static, and placed it intoKubernetesApiAdaptor. I will now do all API calls through this class. If we need to plug in a separate Kubernetes API it will be easy to abstract and then subclassKubernetesApiAdaptor.