Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

provider/kubernetes: Use credentials from ~/.kube/config #335

Merged
merged 1 commit into from
Feb 19, 2016

Conversation

lwander
Copy link
Member

@lwander lwander commented Feb 19, 2016

The user can now point to a kube config file, default is ~./kube/config to authenticate with the kubernetes endpoint.

@duftler

@duftler
Copy link

duftler commented Feb 19, 2016

LGTM. Feel free to self-merge if/when metal travis decides the tests have passed.

@duftler
Copy link

duftler commented Feb 19, 2016

Btw, I think in general that String.isEmpty() makes the intent of the code a bit clearer than using .length() == 0.

@lwander lwander force-pushed the kubernetes-kube-config branch from 4c71d99 to c883146 Compare February 19, 2016 21:37
@lwander
Copy link
Member Author

lwander commented Feb 19, 2016

Switched to .length().

lwander added a commit that referenced this pull request Feb 19, 2016
provider/kubernetes: Use credentials from ~/.kube/config
@lwander lwander merged commit 07740fc into spinnaker:master Feb 19, 2016
@lwander
Copy link
Member Author

lwander commented Feb 19, 2016

.isEmpty()* whoops

luba239 pushed a commit to vasiliy-briginets/clouddriver that referenced this pull request Mar 5, 2020
ttomsu pushed a commit to ttomsu/clouddriver that referenced this pull request Mar 11, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants