provider/kubernetes: One last health tweak... #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
force-pushed
the
kubernetes-fix-health
branch
from
7129e06 to
463f770
Compare
| String type = "Kubernetes" // All healths are reported by Kubernetes | ||
| final String source | ||
| final String type | ||
| final String healthClass = "platform" |
|
LGTM. |
duftler
pushed a commit
that referenced
this pull request
Mar 18, 2016
provider/kubernetes: One last health tweak...
lwander
pushed a commit
to lwander/clouddriver
that referenced
this pull request
Aug 8, 2018
added in a missing ) under configuring AWS section
luba239
pushed a commit
to vasiliy-briginets/clouddriver
that referenced
this pull request
Mar 5, 2020
ttomsu
pushed a commit
to ttomsu/clouddriver
that referenced
this pull request
Mar 11, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@duftler
I'm now labeling the health types by which kubernetes construct they come from (service, pod, container). This allows my to set
interestingHealthProvidersaccordingly. For example, during disable, the only health construct that's relevant isKubernetesService, since pods and containers have separate notions of health.