feat(pipelineRef): conditionally load childExecutions when pipelineRef is enabled #10164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarulg
requested review from
christosarvanitis,
jasonmcintosh,
link108 and
dbyron-sf
danielGz
approved these changes
Feb 20, 2025
jasonmcintosh
approved these changes
Feb 20, 2025
christosarvanitis
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Thanks @edgarulg! This will keep the a consistent experience with not enabled the feature.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pipelineRef is enabled with the following changes: spinnaker/orca#4842
When click on the "View Pipeline Execution" in a execution with PipelineRef trigger Deck is not able to render parentExecution because it does not know how to handle a PipelineRefTrigger.
As part of this changes I defined a new feature flag in deck that conditionally retrieve parent executions when the user visit the SingleExecutionDetails component in the UI.
How to enable
Setting.jsneeds to define the pipelineRefEnabled flag.window.spinnakerSettings.feature.pipelineRefEnabled = true;