Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

provider/kubernetes: Create server group operation propagated to UI #1881

Merged

Conversation

lwander
Copy link
Member

@lwander lwander commented Jan 19, 2016

Note - until I add caching (oort) support, server group create tasks in the tasks view will appear to run forever.

@lwander lwander changed the title provider/kubernetes: Create server group UI propagated to UI provider/kubernetes: Create server group operation propagated to UI Jan 19, 2016
let angular = require('angular');

module.exports = angular.module('spinnaker.kubernetes.serverGroupCommandBuilder.service', [
require('../../../core/cache/deckCacheFactory.js'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this line with:

require('../../../core/config/settings.js'),

I know you were just copying existing code, but that code was wrong! So we might as well fix it here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You caught me

@anotherchrisberry
Copy link
Contributor

Overall, I think this looks fine. There are some small things that can be cleaned up, but nothing that would break anything, as far as I can tell.

@lwander lwander force-pushed the kubernetes-create-server-group branch from 73a3b60 to df572fc Compare January 19, 2016 23:37
@lwander
Copy link
Member Author

lwander commented Jan 19, 2016

@anotherchrisberry PTAL

anotherchrisberry added a commit that referenced this pull request Jan 19, 2016
provider/kubernetes: Create server group operation propagated to UI
@anotherchrisberry anotherchrisberry merged commit df11f9c into spinnaker:master Jan 19, 2016
@tomaslin
Copy link
Contributor

I'm seeing two warnings that seem to be coming from this PR:

/Users/clin/dev/deck/app/scripts/modules/kubernetes/serverGroup/configure/configuration.service.js
50:44 warning "skipCommandReconfiguration" is defined but never used no-unused-vars
54:45 warning "skipCommandReconfiguration" is defined but never used no-unused-vars

and

/Users/clin/dev/deck/app/scripts/modules/kubernetes/image/image.reader.js
6:51 warning "Restangular" is defined but never used no-unused-vars
8:25 warning "params" is defined but never used no-unused-vars
9:79 warning Multiple spaces found before '}' no-multi-spaces

Would be nice if these were cleaned up

@lwander
Copy link
Member Author

lwander commented Jan 22, 2016

@tomaslin, whoops, I'll clean that up when I get in tomorrow

@lwander lwander mentioned this pull request Jan 22, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants