-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
provider/kubernetes: Create server group operation propagated to UI #1881
provider/kubernetes: Create server group operation propagated to UI #1881
Conversation
let angular = require('angular'); | ||
|
||
module.exports = angular.module('spinnaker.kubernetes.serverGroupCommandBuilder.service', [ | ||
require('../../../core/cache/deckCacheFactory.js'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this line with:
require('../../../core/config/settings.js'),
I know you were just copying existing code, but that code was wrong! So we might as well fix it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You caught me
Overall, I think this looks fine. There are some small things that can be cleaned up, but nothing that would break anything, as far as I can tell. |
73a3b60
to
df572fc
Compare
@anotherchrisberry PTAL |
provider/kubernetes: Create server group operation propagated to UI
I'm seeing two warnings that seem to be coming from this PR: /Users/clin/dev/deck/app/scripts/modules/kubernetes/serverGroup/configure/configuration.service.js and /Users/clin/dev/deck/app/scripts/modules/kubernetes/image/image.reader.js Would be nice if these were cleaned up |
@tomaslin, whoops, I'll clean that up when I get in tomorrow |
Note - until I add caching (oort) support, server group create tasks in the tasks view will appear to run forever.