Skip to content

Commit

Permalink
Update pkginfo to 1.10.0
Browse files Browse the repository at this point in the history
This solves a problem parsing some packages which ends up with
`info.name` being `None`. Add an assertion to make the problem more
clear in the future if it comes back.

Bump package version to 1.4.2 (1.4.1 was used in an internal release at
SPI).

Signed-off-by: J Robert Ray <jrray@imageworks.com>
  • Loading branch information
J Robert Ray committed Jul 16, 2024
1 parent 35e3514 commit 1ef30d7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
5 changes: 3 additions & 2 deletions packages/spk-convert-pip/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
pkginfo==1.7.0
# 1.10.0 is the last version that supports python 3.7
pkginfo==1.10.0
packaging==20.9
# 0.40.0 latest at time of writing but no implied requirement for exactly this
# version.
wheel==0.40.0
wheel==0.40.0
1 change: 1 addition & 0 deletions packages/spk-convert-pip/spk-convert-pip
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ class PipImporter:
def _process_package(
self, requester: Requirement, info: pkginfo.Distribution
) -> List[Dict[str, Any]]:
assert info.name, "A package name is required"
assert not info.requires, "No support for installation requirements"
assert not info.requires_external, "No support for external requirements"
assert not info.supported_platforms, "No support for supported platforms field"
Expand Down
2 changes: 1 addition & 1 deletion packages/spk-convert-pip/spk-convert-pip.spk.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pkg: spk-convert-pip/1.4.0
pkg: spk-convert-pip/1.4.2
api: v0/package
build:
script:
Expand Down

0 comments on commit 1ef30d7

Please # to comment.