Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add --no-publish/--no option to spk-convert-pip #1015

Merged
merged 2 commits into from
May 15, 2024

Conversation

dcookspi
Copy link
Collaborator

This adds --no-publish/--no option to the spk-convert-pip script. This allows the user to bypass the "Do you want to also publish these packages? [y/N]: " question, effectively pre-answering it with 'no'.

The spk-convert-pip script already has a --publish option, which effectively answers 'yes' to the question and goes on to publish the converted packages. But when I was porting python tools from one OS to another, and between one python version and another, I needed a smoother way to convert, but not publish, various versions of python modules. I didn't want to publish each converted version while narrowing down the dependencies for the port, because I knew the latest versions might not play well with other modules. But answering 'no' manually for each conversion was tedious. I added --no to this command to streamline it.

This allows the user by pass the "Do you want to also publish these
packages? [y/N]: " question, effectively pre-answering it with 'no'.

Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
@dcookspi dcookspi self-assigned this Apr 29, 2024
@dcookspi dcookspi requested review from jrray and rydrman April 29, 2024 21:48
@dcookspi dcookspi added enhancement New feature or request SPI AOI Area of interest for SPI SPI-0.41 labels Apr 30, 2024
Copy link
Collaborator

@rydrman rydrman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but looks good otherwise

packages/spk-convert-pip/spk-convert-pip Outdated Show resolved Hide resolved
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
@dcookspi dcookspi merged commit cd83051 into main May 15, 2024
7 checks passed
@dcookspi dcookspi deleted the spk-convert-pip-add-no-publish branch May 15, 2024 19:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request SPI AOI Area of interest for SPI SPI-0.41
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants