Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch from Prettier to Rubocop #269

Merged
merged 9 commits into from
Oct 22, 2024
Merged

Switch from Prettier to Rubocop #269

merged 9 commits into from
Oct 22, 2024

Conversation

jas14
Copy link
Collaborator

@jas14 jas14 commented Oct 22, 2024

This project currently has three language dependencies for development:

  • Ruby, for the library code and testing
  • Javascript, for linting with Prettier and installing commit hooks with Husky
  • Python, for creating the docsite

In an effort to reduce these dependencies, I'm moving to eliminate JS from the dev environment, starting with Prettier. I may replace Husky with Overcommit or a bespoke script.

jas14 added 4 commits October 21, 2024 23:28
This project currently has three language dependencies for development:

* Ruby, for the library code and testing
* Javascript, for linting with Prettier and installing commit hooks with
  Husky
* Python, for creating the docsite

In an effort to reduce these dependencies, I'm moving to eliminate JS
from the dev environment, starting with Prettier. I may replace Husky
with Overcommit or a bespoke script.
We need to bundle install!
This is now recommended by Bundler for a consistent dev environment.
Copy link

📖 A new version of the docsite has been published at: https://splitwise.github.io/super_diff/branches/rubocop/3012222070e7f1ffdbd3b7cbf7626489f3d8070d

Copy link

📖 A new version of the docsite has been published at: https://splitwise.github.io/super_diff/branches/rubocop/8db5b2c0f13c7e30e568814397b0ef901d618f36

Copy link

📖 A new version of the docsite has been published at: https://splitwise.github.io/super_diff/branches/rubocop/17e79d6395ddb751efb4288f50600bcb5bf3636c

Copy link

📖 A new version of the docsite has been published at: https://splitwise.github.io/super_diff/branches/rubocop/e552b75e8ba7dba2d81c2f4e827331ab4d2a1071

@jas14 jas14 merged commit 25ceb5f into main Oct 22, 2024
31 checks passed
@jas14 jas14 deleted the rubocop branch October 22, 2024 21:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant