pin to requests 2.31 to resolve docker library error #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker library error
… longer installed by default in python 3.12 environments. However, pycvesearch uses/requires it, so we install it.
patel-bhavin
approved these changes
May 20, 2024
|
requests |
|
Merging this query and then will create another PR when a more stable fix is out! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This morning, python requests library 2.32 was pushed.
However, this breaks docker-py: docker/docker-py#3256
Since docker-py is a dependency, we must pin to request
~2.31for nowWe also have added setuptools, which is not installed by default in Python 3.12: Link to Python 3.12 release notes
To pyproject.toml since it is used in pycvesearch: https://github.com/cve-search/PyCVESearch/blob/6a492a72f95ea96f1ef56109d138dfa344d7e9ec/pycvesearch/core.py#L4