Task/increase test coverage #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwang92
requested review from
bb03,
lephino,
arctan5x,
jonathan-vega-splunk and
jmeixensperger
|
Are we abiding by the CircleCI testing now? |
|
@jmeixensperger yes we consider the CI results gating. There's a few test failures, waiting on some splunk-ansible changes to make it into develop. |
This was referenced Jan 31, 2019
arctan5x
approved these changes
Feb 4, 2019
bb03
reviewed
Feb 4, 2019
| # Poll for the container to be ready | ||
| assert self.wait_for_containers(1, name=splunk_container_name) | ||
| # Check splunkd | ||
| splunkd_port = self.client.port(cid, 8089)[0]["HostPort"] |
There was a problem hiding this comment.
It seems like theres a bit of code duplication on this segment, where you verify splunk is up and responding at the /services/server/info path. Would this be better as its own method, to avoid the duplication?
There was a problem hiding this comment.
+1, there is already a method that does this but I don't think I call it here and probably should. I'll fix this in my next PR when I add more tests.
bb03
approved these changes
Feb 4, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.