Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update videojs (tested 5-7). Update Play, Seek, Pause Event #30

Merged
merged 5 commits into from
Mar 21, 2022

Conversation

spodlecki
Copy link
Owner

PR Description, what changed?

  • Removed eslintcache file
  • Adds a PR Template file GitHub
  • Changing dependency requirements for VideoJS. We I tested backwards to VideoJS 5.20.5 (release Feb 13, 2018)
  • The examples file will now display the version of videojs that we're using
  • Tracking the seek event using seeking
  • Updates pause event to depend on the videojs seeking() and/or scrubbing() functions
  • Reset the onSecondsToLoad in the Play event when the video is ended

Steps for testing

  • Change the videojs version from 5, 6, and 7.
yarn install
yarn start
open ./index.html

@spodlecki spodlecki added bug dependencies Pull requests that update a dependency file labels Mar 21, 2022
@spodlecki spodlecki self-assigned this Mar 21, 2022
@spodlecki spodlecki merged commit fc42db7 into master Mar 21, 2022
@spodlecki spodlecki deleted the update-deps-and-play-tracking branch March 21, 2022 17:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant