Add ALPN Protocols Client & Server config option #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example: update sync example with alpn_protocols config
spoorn
reviewed
Dec 10, 2022
example/src/main.rs
Outdated
| @@ -67,7 +69,8 @@ fn sync_example() { | |||
| // clients, as well as the total number of expected clients (or None if server can accept any | |||
| // number of clients). A thread will be spun up to wait for extra clients beyond the number | |||
| // to block on. | |||
| let server_config = ServerConfig::new(server_addr, 0, Some(1), 3, 2); | |||
| let mut server_config = ServerConfig::new(server_addr, 0, Some(1), 3, 2); | |||
| server_config.with_alpn_protocols(alpn_protocols); | |||
There was a problem hiding this comment.
I would like to keep the actual example code a minimal example. Could you either add this as a comment like:
// Here you can set various optional configurations
// server_config.with_alpn_protocols(&[b"hq-29"]);
Same with the client config below
spoorn
approved these changes
Dec 10, 2022
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a client & server config option to pass in ALPN protocols. It is empty by default.
This includes a new
with_alpn_protocols()method forClientConfigandServerConfig.