-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove redundant colon in Addressable::URI::CharacterClasses::AUTHORITY #438
Remove redundant colon in Addressable::URI::CharacterClasses::AUTHORITY #438
Conversation
CI test failed on Ruby Devel: It seems internal error in an unstable Ruby. |
debug all ci or authority |
Bug found in the used |
@masterofmasters13 please approve workflow, now all tests should become passed with latest |
can we please scan and eliminate all bugs im currently very busy and still
learning the deveopment ins and outs
…On Mon, Nov 1, 2021 at 8:22 PM Dmitry Ukolov ***@***.***> wrote:
@masterofmasters13 <https://github.com/masterofmasters13> please approve
workflow, now all tests should pass with latest idn-ruby 0.1.4.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#438 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWJDXP4A65KZ4RB4SMQAS2TUJ4VMDANCNFSM5FUAJHEA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@ukolovda I approved the CI, I don't know who @masterofmasters13 is, the account joined GitHub just two days ago |
Ohh... Sorry. CI is green now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me!
I can only see Addressable::URI::CharacterClasses::AUTHORITY
being used at
addressable/lib/addressable/uri.rb
Lines 628 to 629 in 901e563
:authority => self.encode_component(uri_object.authority, | |
Addressable::URI::CharacterClasses::AUTHORITY), |
In encode_component
it is then always used in this way:
addressable/lib/addressable/uri.rb
Line 389 in 901e563
def self.encode_component(component, character_class= |
addressable/lib/addressable/uri.rb
Lines 411 to 413 in 901e563
if character_class.kind_of?(String) | |
character_class = /[^#{character_class}]/ | |
end |
which triggers the warning:
$ irb -w -r addressable/uri
irb(main):001:0> Addressable::VERSION::STRING
=> "2.8.0"
irb(main):002:0> Regexp.compile("[#{Addressable::URI::CharacterClasses::AUTHORITY}]")
(irb):2: warning: character class has duplicated range: /[a-zA-Z0-9\-\.\_\~\!\$\&\'\(\)\*\+\,\;\=\:\@\[\:\]]/
=> /[a-zA-Z0-9\-\.\_\~\!\$\&\'\(\)\*\+\,\;\=\:\@\[\:\]]/
Addressed to #437