Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

restore unicode_normalize_kc as a deprecated method #504

Merged
merged 1 commit into from
Apr 9, 2023
Merged

restore unicode_normalize_kc as a deprecated method #504

merged 1 commit into from
Apr 9, 2023

Conversation

jarthod
Copy link
Contributor

@jarthod jarthod commented Apr 6, 2023

As discussed in #492 (comment), this is the PR to restore unicode_normalize_kc as a deprecated method (in case some people where using it). Example of the produced warning:

NOTE: Addressable::IDNA.unicode_normalize_kc is deprecated; use String#unicode_normalize(:nfkc) instead. It will be removed on or after 2023-04.
Addressable::IDNA.unicode_normalize_kc called from benchmark/unicode_normalize.rb:17.

@jarthod jarthod mentioned this pull request Apr 6, 2023
Merged
@dentarg dentarg merged commit b460cb7 into sporkmonger:main Apr 9, 2023
@jarthod jarthod deleted the restore-unicode_normalize_kc branch April 11, 2023 14:16
Bizzyfortune
Bizzyfortune reviewed Apr 27, 2023
View reviewed changes
Copy link

@Bizzyfortune Bizzyfortune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Bizzyfortune Bizzyfortune Bizzyfortune left review comments

@dentarg dentarg dentarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarthod @dentarg @Bizzyfortune