Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

save() ignores write failures, causing corrupt annoy trees #379

Closed
keithmcneill opened this issue Apr 8, 2019 · 1 comment
Closed

save() ignores write failures, causing corrupt annoy trees #379

keithmcneill opened this issue Apr 8, 2019 · 1 comment

Comments

@keithmcneill
Copy link
Contributor

In particular if the disk is full, the annoy tree will be silently truncated.

Working on a fix on a fork.
keithmcneill added a commit to keithmcneill/annoy that referenced this issue Apr 8, 2019
@keithmcneill
Fix for spotify#379, save() ingores write failures, implmented test f…
23c44b0 
…or mac
erikbern added a commit that referenced this issue Apr 8, 2019
@erikbern
Merge pull request #380 from keithmcneill/master
31015fd 
Fix for #379, save() ignores write failures
@erikbern erikbern closed this as completed Apr 8, 2019
@erikbern
Copy link
Collaborator

erikbern commented Apr 8, 2019

thanks for the fix!

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikbern @keithmcneill