Skip to content

Commit

Permalink
Fix python3 dataflow naming (#214)
Browse files Browse the repository at this point in the history
  • Loading branch information
konstsoz authored and rculbertson committed Aug 27, 2019
1 parent b9f4ae5 commit 24913cd
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion spotify_tensorflow/luigi/python_dataflow_task.py
Original file line number Diff line number Diff line change
@@ -103,7 +103,7 @@ def __init__(self, *args, **kwargs):
# job_name must consist of only the characters [-a-z0-9]
cls_name = self.__class__.__name__.replace("_", "-").lower()
self.job_name = "{cls_name}-{timestamp}".format(cls_name=cls_name,
timestamp=str(time.time())[:-3])
timestamp=str(int(time.time())))

def on_successful_run(self):
""" Callback that gets called right after the dataflow job has finished successfully but
2 changes: 1 addition & 1 deletion spotify_tensorflow/tfx/tfdv.py
Original file line number Diff line number Diff line change
@@ -151,7 +151,7 @@ def generate_statistics_from_tfrecord(pipeline_args, # type: List[str]

if all_options["job_name"] is None:
gcloud_options = pipeline_options.view_as(GoogleCloudOptions)
gcloud_options.job_name = "generatestats-%s" % str(time.time())[:-3]
gcloud_options.job_name = "generatestats-%s" % str(int(time.time()))

if all_options["setup_file"] is None:
setup_file_path = create_setup_file()

0 comments on commit 24913cd

Please # to comment.