Skip to content
This repository was archived by the owner on Mar 2, 2022. It is now read-only.

SMono.cast/ofType now accept implicit ClassTag instead of Class #33

Merged
merged 2 commits into from
Aug 19, 2019

Conversation

rs017991
Copy link
Contributor

This change allows a user to write code like:

myMono.cast[String]

... instead of:

myMono.cast(classOf[String])

SFlux.cast/ofType were already written this way; I merely changed SMono to do it as well.

Note that this would be a breaking change, but perhaps you will agree that this is appropriate for v0.5.0?

@sinwe
Copy link
Contributor

sinwe commented Aug 17, 2019

@rs017991 Thanks for your PR.
I agree that this is a breaking changes and should go to v0.5.0.
However this change is making it consistent with SFlux. How about we retain the myMono.cast(classOf[String]) one while adding the myMono.cast[String] and put @deprecated on the prior?

@rs017991
Copy link
Contributor Author

@sinwe It didn't occur to me that the two could co-exist, but I think you're right.

I'll give that a shot

@sinwe sinwe merged commit 8999496 into spring-attic:master Aug 19, 2019
@rs017991 rs017991 deleted the castClass branch August 19, 2019 19:33
@sinwe
Copy link
Contributor

sinwe commented Aug 28, 2019

Released on v0.4.6

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants