Fix conversion to Scala Future

[chetanmeh]

Current implementation for future conversion does not work for cases where Mono was completed with a null/void result.

https://github.com/reactor/reactor-scala-extensions/blob/8ecf0d5fd4fad34b8886499aa03993045e00ce65/src/main/scala/reactor/core/scala/publisher/SMono.scala#L1300-L1308

Here due to use of Option with value the promise would not be completed if the value is null. On the other hand the way Scala Future compat logic handles this by passing a BiConsumer which considers the throwable == null case as Success else a Failure

class P[T](val wrapped: CompletionStage[T]) extends DefaultPromise[T] with BiConsumer[T, Throwable] {
    override def accept(v: T, e: Throwable): Unit = {
      if (e == null) complete(Success(v))
      else complete(Failure(e))
    }
  }

As a result this PR fixes the current issue by completing promise with success if throwable is null

[pivotal-issuemaster]

@chetanmeh Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-issuemaster]

@chetanmeh Thank you for signing the Contributor License Agreement!

[sinwe]

@chetanmeh Thank you for your PR. I've put up a comment. If you could address it quickly, I can merge it to master and cut a version

[chetanmeh]

I've put up a comment. If you could address it quickly, I can merge it to master and cut a version

@sinwe I do not see any comment here. May be you missed submitting the review?

[sinwe]

I've put up a comment. If you could address it quickly, I can merge it to master and cut a version

@sinwe I do not see any comment here. May be you missed submitting the review?

@chetanmeh Sorry, forgotten to submit the review :). Now submitted already

[sinwe]

@chetanmeh I've merged into master. Unless there is anymore PR in the next 1-2 days, I'll cut a release version.

[chetanmeh]

Thanks @sinwe for the prompt review and merge.

[sinwe]

@chetanmeh It is released on https://github.com/reactor/reactor-scala-extensions/releases/tag/0.4.7