Added metrics to SFlux/SMono #56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 80.20% 80.27% +0.06%
==========================================
Files 17 17
Lines 576 578 +2
Branches 8 5 -3
==========================================
+ Hits 462 464 +2
Misses 114 114
Continue to review full report at Codecov.
|
| @@ -1526,6 +1526,11 @@ class SFluxTest extends AnyFreeSpec with Matchers with TableDrivenPropertyChecks | |||
| .expectNext(1, 2, 3, 4, 5, 6) | |||
| .verifyComplete() | |||
| } | |||
|
|
|||
| ".metrics should be a nop since Micrometer is not on the classpath" in { | |||
There was a problem hiding this comment.
Could you also add a test with Micrometer on the classpath? You can add the library for test.
| @@ -163,6 +163,11 @@ class SMonoTest extends AnyFreeSpec with Matchers with TestSupport with Idiomati | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| ".metrics should be a nop since Micrometer is not on the classpath" in { | |||
There was a problem hiding this comment.
Same as SFluxTest, if you can add Micrometer on test classpath and add the test here that'd be good.
|
Thank you @rs017991 |
|
@sinwe after some thought, I'm leaning towards changing the tests to be micrometer-only. I think that would be more valuable. Testing both scenarios would be overly complex, if even possible. Will follow up with another PR |
I went ahead and copied the docs from the core reactor project, I hope that's okay.