Skip to content

Remove HttpClient Interfaces and Classes #1171

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
ryanjbaxter opened this issue Nov 15, 2022 · 4 comments
Closed

Remove HttpClient Interfaces and Classes #1171

ryanjbaxter opened this issue Nov 15, 2022 · 4 comments
Milestone

Comments

@ryanjbaxter
Copy link
Contributor

The classes and interfaces in org.springframework.cloud.commons.httpclient are only used by Spring Cloud OpenFeign. Other projects no longer use them. We can remove these classes and interfaces and move the necessary code to Spring Cloud OpenFeign. In addition Spring Framework 6 has removed support for Apache HttpClient v4 so we should be using HttpClient v5, which OpenFeign already has support for.

@akhgeek30
Copy link

@ryanjbaxter Since the package is removed, and move to OpenFeign, where can I find the OkHttpClientConnectionPoolFactory, and OkHttpClientFactory classes?

@ryanjbaxter
Copy link
Contributor Author

It is not used anymore since we no longer need those abstractions
spring-cloud/spring-cloud-openfeign#788

@sshefferly
Copy link

@ryanjbaxter Given this change, I assume the HTTP Client Factory documentation at
https://docs.spring.io/spring-cloud-commons/reference/4.2.1/spring-cloud-commons/common-abstractions.html#http-clients
is now irrelevant/incorrect?
What is now the best way to customize the Apache HttpClient 5 connection pool? (Stack Overflow: https://stackoverflow.com/questions/79597280/configure-max-http-connections-on-spring-cloud-gateway-mvc-route )

ryanjbaxter added a commit that referenced this issue Apr 29, 2025
Support was removed in #1171

Signed-off-by: Ryan Baxter <ryan.baxter@broadcom.com>
@ryanjbaxter
Copy link
Contributor Author

Good find I removed that documentation 99e710d

Can you open an issue in Spring Cloud Gateway regarding your gateway configuration question

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants