Optimize instance selection performance #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaMaciaszek
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Hello @qnnn. Thanks for the PR. It's a neat optimisation. Please add your full name and surname with @author tag to the javadocs of all the classes you've modified. Please update the dates in the license docs to 2012-2024.
...lancer/src/main/java/org/springframework/cloud/loadbalancer/core/RoundRobinLoadBalancer.java
Outdated
Show resolved
Hide resolved
|
@OlgaMaciaszek Thanks! I've completed as requested. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time instance selection is performed during a request, the
ObjectProvider#getIfAvailablemethod is called, and its reflection implementation causes some CPU consumption.