Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use newCachedTreadPool() instead of newSingleThreadExecutor() in InetUtils #1365

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

stsypanov
Copy link
Contributor

See #1364

@OlgaMaciaszek
Copy link
Collaborator

Fixes gh-1364.

Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stsypanov. Thanks for adding the PR. However, could you please submit the change against the 4.1.x branch instead? Also, please add your full name and last name with the @author tag to the class Javadoc and update the date in the license comment to 2012-2024

@stsypanov
Copy link
Contributor Author

stsypanov commented Sep 17, 2024

@OlgaMaciaszek done! I've also removed TODO comment as the executor is shut down in close() method and shutting it down before calling close() doesn't make sence if we use newCachedThreadPool().

@stsypanov stsypanov changed the title Fix issue 1364 Use newCachedTreadPool() instead of newSingleThreadExecutor() in InetUtils Sep 18, 2024
@OlgaMaciaszek OlgaMaciaszek added this to the 4.1.5 milestone Sep 25, 2024
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stsypanov. LGTM.

@OlgaMaciaszek OlgaMaciaszek merged commit 715fb9f into spring-cloud:4.1.x Sep 25, 2024
@stsypanov stsypanov deleted the issue-1364 branch September 25, 2024 12:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants