Support multiple labels in NativeEnvironmentRepository

[ryanjbaxter]

Related to #2449

[spencergibb]

Maybe for main?

[kvmw]

@spencergibb

Is the change in this PR is just for this particular repository or it supposed to be implemented by all other repositories? I am thinking about JGitEnvironmentRepository and other similar repos. I don't think supporting multiple labels would be easy for JGitEnvironmentRepository
.

[ryanjbaxter]

I am curious why you think it would not be easy for JGitEnvironmentRepository?

[ryanjbaxter]

I guess I see why now since a label corresponds to a branch and we can only checkout and use a single branch at a time

[kvmw]

yes, And It uses NativeEnvironmentRepository via AbstractScmEnvironmentRepository internally.

So I supposed we need to split the label and for each entry we have to run what is currently in AbstractScmEnvironmentRepository::findOne.

Something like:

var labels = label.split(",");
for (String lbl : labels) {
                NativeEnvironmentRepository delegate = new NativeEnvironmentRepository(getEnvironment(),
				new NativeEnvironmentProperties(), this.observationRegistry);
		Locations locations = getLocations(application, profile, lbl);
		delegate.setSearchLocations(locations.getLocations());
		Environment result = delegate.findOne(application, profile, "", includeOrigin);
		result.setVersion(locations.getVersion());
		result.setLabel(lbl);
}

I am just worried about the impact of such a change. Maybe I am just being oversuspicious.