Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Initial implementation to support multiple labels in SVN and Git EnvironmentRepos #2561

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ryanjbaxter
Copy link
Contributor

No description provided.

@ryanjbaxter
Copy link
Contributor Author

@kvmw here is an initial implementation for SCM repositories. Let me know what you think

@kvmw
Copy link
Contributor

kvmw commented Sep 27, 2024

I've tried this locally and it is not returning back the property sources I was expecting.

I believe the findOne method should be called for each individual repo, rather than once for the composite repo. Because locations have overlap in different branches, with the current approach, we are able to search the locations of last git fetch.

@ryanjbaxter
Copy link
Contributor Author

@kvmw you are right. It works fine for SVN because it uses different directories for branches but git does not. I removed the use of composite, let me know if that works as you expect

@ryanjbaxter ryanjbaxter linked an issue Oct 1, 2024 that may be closed by this pull request
@ryanjbaxter ryanjbaxter merged commit 73f4bf5 into spring-cloud:main Oct 2, 2024
1 check passed
@kvmw
Copy link
Contributor

kvmw commented Oct 9, 2024

@ryanjbaxter Yes, it is working as expected with my sample configs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Multiple Labels In Environment Repositories
3 participants