Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade Hystrix to 1.5.18 #3281

Closed
wants to merge 1 commit into from
Closed

Conversation

tinexw
Copy link
Contributor

@tinexw tinexw commented Nov 19, 2018

Hystrix 1.5.11 was re-released as 1.5.18 because this is the version that is internally used at Netflix and is considered more stable, s. Netflix/Hystrix#1891 and https://github.com/Netflix/Hystrix/releases/tag/v1.5.18

@codecov-io
Copy link

codecov-io commented Nov 19, 2018

Codecov Report

Merging #3281 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3281      +/-   ##
============================================
+ Coverage     65.28%   65.35%   +0.07%     
- Complexity     1477     1481       +4     
============================================
  Files           188      188              
  Lines          6965     6965              
  Branches        847      847              
============================================
+ Hits           4547     4552       +5     
+ Misses         2104     2103       -1     
+ Partials        314      310       -4
Impacted Files Coverage Δ Complexity Δ
...oud/netflix/zuul/filters/post/SendErrorFilter.java 76.36% <0%> (+3.63%) 17% <0%> (+1%) ⬆️
...x/security/SecurityContextConcurrencyStrategy.java 77.77% <0%> (+16.66%) 8% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5f246...dc4473b. Read the comment docs.

@spencergibb spencergibb changed the title Upgrade Hystrix Upgrade Hystrix to 1.5.18 Nov 19, 2018
@ryanjbaxter
Copy link
Contributor

@tinexw would you mind submitting this against the 2.0.x branch? Then we can just merge it forward into master.

@ryanjbaxter ryanjbaxter added this to the 2.1.0.RC1 milestone Nov 20, 2018
@tinexw tinexw changed the base branch from master to 2.0.x November 20, 2018 19:08
@tinexw tinexw changed the base branch from 2.0.x to master November 20, 2018 19:08
@tinexw
Copy link
Contributor Author

tinexw commented Nov 20, 2018

@ryanjbaxter Sure

@tinexw
Copy link
Contributor Author

tinexw commented Nov 20, 2018

I created a new PR (#3288) against the 2.0.x branch. Closing this one.

@tinexw tinexw closed this Nov 20, 2018
@spencergibb spencergibb removed the task label Nov 20, 2018
@spencergibb spencergibb removed this from the 2.1.0.RC1 milestone Nov 20, 2018
spencergibb pushed a commit that referenced this pull request Nov 20, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants