Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Shut down client on stop. #4213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Shut down client on stop. #4213

wants to merge 1 commit into from

Conversation

OlgaMaciaszek
Copy link
Collaborator

No description provided.

@OlgaMaciaszek OlgaMaciaszek added this to the 4.1.0-RC1 milestone Oct 19, 2023
@OlgaMaciaszek OlgaMaciaszek self-assigned this Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (522905b) 55.62% compared to head (dbbde33) 55.67%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4213      +/-   ##
============================================
+ Coverage     55.62%   55.67%   +0.04%     
- Complexity      527      529       +2     
============================================
  Files            58       58              
  Lines          2684     2698      +14     
  Branches        249      251       +2     
============================================
+ Hits           1493     1502       +9     
- Misses         1104     1108       +4     
- Partials         87       88       +1     
Files Coverage Δ
...mework/cloud/netflix/eureka/CloudEurekaClient.java 35.29% <47.82%> (+10.96%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanjbaxter
Copy link
Contributor

How is this assisting with CraC support?

@spencergibb
Copy link
Member

Anything with Lifecycle implementations is where checkpoint restore comes in

@spencergibb spencergibb removed this from the 4.1.0-RC1 milestone Dec 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants