Block attributes are ignored when determining chomp package replacement #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Wilkinson <andy.wilkinson@broadcom.com>
wilkinsona
force-pushed
the
chomp-package-replacment-block-attributes
branch
from
a434554 to
df097ba
Compare
philwebb
pushed a commit
that referenced
this pull request
Jan 27, 2025
See gh-24 Signed-off-by: Andy Wilkinson <andy.wilkinson@broadcom.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, configuring
chomp-package-replacementat the block level (rather than the document level) has no effect.chompcan already be configured at the block level so this change aligns the two.