Fix ollama IT execution

spring-projects · Nov 19, 2024 · 4363c95 · 4363c95
1 parent 20f0477
commit 4363c95
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.github/actions/do-integration-test/action.yml b/.github/actions/do-integration-test/action.yml
@@ -5,6 +5,10 @@ inputs:
   model-name:
     description: "SpringAI Model to integration test"
     required: true
+  maven-properties:
+    description: "Maven properties to pass to the build (e.g., -Dskip.vectorstore.milvus=true -Dskip.vectorstore.neo4j=true)"
+    required: false
+    default: ""
 
 runs:
   using: "composite"
@@ -38,4 +42,4 @@ runs:
 
     - name: Run ${{ inputs.model-name }} model tests
       shell: bash
-      run: cd spring-ai && ./mvnw -pl models/spring-ai-${{ inputs.model-name }} -Pintegration-tests -Dfailsafe.rerunFailingTestsCount=2 verify
+      run: cd spring-ai && ./mvnw -pl models/spring-ai-${{ inputs.model-name }} -Pintegration-tests ${{ inputs.maven-properties }} -Dfailsafe.rerunFailingTestsCount=2 verify
diff --git a/.github/workflows/spring-ai-integration-tests.yml b/.github/workflows/spring-ai-integration-tests.yml
@@ -16,7 +16,6 @@ jobs:
         ports:
           - 11434:11434
     env:
-      OLLAMA_TESTS_ENABLED: true
       OLLAMA_WITH_REUSE: true
     steps:
       - name: Checkout the action
@@ -37,6 +36,7 @@ jobs:
         uses: ./.github/actions/do-integration-test
         with:
           model-name: ollama
+          maven-properties: "-Dskip.model.ollama=false"
 
 # Anthrohpic is overloaded :(
 #